Skip to content

Throw if resolving keyed service from non-keyed container #53051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2024
Merged

Throw if resolving keyed service from non-keyed container #53051

merged 4 commits into from
Jan 9, 2024

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 29, 2023

Closes #50277

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 29, 2023
@captainsafia captainsafia added feature-rdg area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Dec 29, 2023
JamesNK
JamesNK reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a couple of unit tests.

@ghost
Copy link

ghost commented Jan 6, 2024

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 6, 2024
@captainsafia captainsafia removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 8, 2024
@captainsafia captainsafia enabled auto-merge (squash) January 9, 2024 00:23
@JamesNK JamesNK mentioned this pull request Jan 9, 2024
Merged
@captainsafia captainsafia merged commit 252ad5d into main Jan 9, 2024
@captainsafia captainsafia deleted the safia/gh/50277 branch January 9, 2024 01:43
@ghost ghost added this to the 9.0-preview1 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg

Projects

None yet

Milestone

9.0-preview1

Development

Successfully merging this pull request may close these issues.

Only use keyed services when keyed service provider is available

3 participants

@captainsafia @JamesNK