Skip to content

Use an image w/ node for SourceBuild #52969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Use an image w/ node for SourceBuild #52969

wants to merge 5 commits into from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Dec 22, 2023

No description provided.

@wtgodbe wtgodbe requested a review from javiercn December 22, 2023 17:17
@wtgodbe wtgodbe requested a review from a team as a code owner December 22, 2023 17:18
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 22, 2023
@wtgodbe wtgodbe changed the title Install node during SourceBuild Use an image w/ node for SourceBuild Dec 22, 2023
@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 22, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe wtgodbe requested a review from a team as a code owner December 22, 2023 18:16
@ghost
Copy link

ghost commented Dec 30, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 30, 2023
@mthalman
Copy link
Member

mthalman commented Jan 2, 2024

@MichaelSimons - Are we able to take a dependency on Node?

@javiercn
Copy link
Member

javiercn commented Jan 2, 2024

See #46304 and #37398 for context.

@MichaelSimons
Copy link
Member

@MichaelSimons - Are we able to take a dependency on Node?

Yes, this was the plan discussed at the beginning of .NET 8.0 IIRC. cc @dotnet/distro-maintainers for awareness and to raise any concerns.

javiercn
javiercn reviewed Jan 8, 2024
View reviewed changes
@javiercn
Copy link
Member

javiercn commented Jan 9, 2024

@wtgodbe closing this as we integrated the change in the other PR

@javiercn javiercn closed this Jan 9, 2024
@omajid
Copy link
Member

omajid commented Jan 9, 2024

The other PR was #53209, right?

@ghost
Copy link

ghost commented Jan 9, 2024

Hi @omajid. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@javiercn
Copy link
Member

javiercn commented Jan 9, 2024

@omajid that PR got merged into the branch in #53154 which got merged into main yesterday

@wtgodbe wtgodbe deleted the wtgodbe/NodeSB branch September 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn left review comments

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wtgodbe @mthalman @javiercn @MichaelSimons @omajid @sebastienros