-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/8.0] Fix app_offline detection for some OSes #52810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
Approved over email. |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Backport of #52780 to release/8.0
/cc @BrennanConroy
Fix app_offline detection for some OSes
Description
On some OSes (Windows Server 2012 R2), shutting down an IIS hosted app hangs forever due to this regression. Fortunately when we made the change we put in a fallback via an environment variable so folks can be unblocked. But we should revert the part that caused the hangs.
Fixes the issues listed below.
Customer Impact
Customer issues #52307 and #52539, and possibly #52525
Regression?
Regressed from 7.0.
Risk
Just reverting part of the regression change to what it was before in 7.0.
Verification
Packaging changes reviewed?