Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 14, 2023

Backport of #52780 to release/8.0

/cc @BrennanConroy

Fix app_offline detection for some OSes

Description

On some OSes (Windows Server 2012 R2), shutting down an IIS hosted app hangs forever due to this regression. Fortunately when we made the change we put in a fallback via an environment variable so folks can be unblocked. But we should revert the part that caused the hangs.

Fixes the issues listed below.

Customer Impact

Customer issues #52307 and #52539, and possibly #52525

Regression?

  • Yes
  • No

Regressed from 7.0.

Risk

  • High
  • Medium
  • Low

Just reverting part of the regression change to what it was before in 7.0.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 14, 2023
@ghost ghost added this to the 8.0.x milestone Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@adityamandaleeka adityamandaleeka added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@adityamandaleeka
Copy link
Member

Approved over email.

@ghost
Copy link

ghost commented Dec 22, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 22, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Jan 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe wtgodbe merged commit 79e8659 into release/8.0 Jan 4, 2024
@wtgodbe wtgodbe deleted the backport/pr-52780-to-release/8.0 branch January 4, 2024 04:51
@ghost ghost modified the milestones: 8.0.x, 8.0.2 Jan 4, 2024
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun Servicing-approved Shiproom has approved the issue

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants