[Blazor] Fix Microsoft.AspNetCore.Components.WebView.props not getting packed correctly
#52638
Conversation
ghost
added
the
|
@Eilon how can we test this in such a way that we cover the path we missed in testing the original change? Can MAUI test privates? |
|
By the time this reaches maui, it is very late. We have to wait for aspnet, runtime, android and ios - then the sdk and possibly installer. nd then still we may not pick it up because we typically build with public versions from nuget.org. |
I'll try to run locally. |
|
From what I observed, you shouldn't need MAUI to test if this change fixes the problem. You could add this package to a console app and build it -- it was failing during MSBuild evaluation before. |
|
Can we get this merged to see if it helps with ou net9 builds? Thanks |
|
Are we OK to merge this? I haven't run locally yet but it seems obviously the right fix. It's blocking MAUI net9 now. |
|
/backport to release/8.0 |
|
Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7302458310 |
|
/backport to release/7.0 |
|
Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/7302524801 |
|
/backport to release/6.0 |
|
Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/7302542081 |
Backport of #52638 to release/8.0 /cc @MackinnonBuck # Fix `Microsoft.AspNetCore.Components.WebView.props` not getting packed correctly Fixes an issue where `Microsoft.AspNetCore.Components.WebView.props` was not getting packed correctly. This was causing build failures for any project referencing `Microsoft.AspNetCore.Components.WebView`. ## Description Fixes #52637 ## Customer Impact If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of `Microsoft.AspNetCore.Components.WebView` until this issue gets fixed. ## Regression? - [X] Yes - [ ] No Regressed from package version 8.0.0. ## Risk - [ ] High - [ ] Medium - [X] Low The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A [MAUI dependency update](dotnet/maui#19236) was failing due to this bug, and the fix has shown to address it. ## Verification - [X] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A Co-authored-by: Mackinnon Buck <[email protected]>
Backport of #52638 to release/7.0 /cc @MackinnonBuck # Fix `Microsoft.AspNetCore.Components.WebView.props` not getting packed correctly Fixes an issue where `Microsoft.AspNetCore.Components.WebView.props` was not getting packed correctly. This was causing build failures for any project referencing `Microsoft.AspNetCore.Components.WebView`. ## Description Fixes #52637 ## Customer Impact If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of `Microsoft.AspNetCore.Components.WebView` until this issue gets fixed. ## Regression? - [X] Yes - [ ] No Regressed from package version 7.0.14. ## Risk - [ ] High - [ ] Medium - [X] Low The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A [MAUI dependency update](dotnet/maui#19236) was failing due to this bug, and the fix has shown to address it. ## Verification - [X] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A Co-authored-by: Mackinnon Buck <[email protected]>
Backport of #52638 to release/6.0 /cc @MackinnonBuck # Fix `Microsoft.AspNetCore.Components.WebView.props` not getting packed correctly Fixes an issue where `Microsoft.AspNetCore.Components.WebView.props` was not getting packed correctly. This was causing build failures for any project referencing `Microsoft.AspNetCore.Components.WebView`. ## Description Fixes #52637 ## Customer Impact If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of `Microsoft.AspNetCore.Components.WebView` until this issue gets fixed. ## Regression? - [X] Yes - [ ] No Regressed from package version 6.0.25. ## Risk - [ ] High - [ ] Medium - [X] Low The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A [MAUI dependency update](dotnet/maui#19236) was failing due to this bug, and the fix has shown to address it. ## Verification - [X] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A Co-authored-by: Mackinnon Buck <[email protected]>
Fixes #52637