Fix Http/3 tests #50852
Merged
Fix Http/3 tests #50852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
area-networking
BrennanConroy
requested review from
JamesNK,
Tratcher,
halter73 and
mgravell
as code owners
Member
|
The tests shouldn't need to do this. I think S.N.Q or HttpClient is wrong. See dotnet/runtime#92390 |
Member
Author
Shouldn't need to, but probably should anyways? Unless we're explicitly testing hanging in |
Member
|
The client not completing the request is a legitimate scenario. We wouldn't have caught this bug if we were cleaning up everything correctly. |
Member
Author
|
I'm not disagreeing, but that should be an explicit test (preferably done by the client team). |
Member
|
The other tests abort the client. Adding |
Tratcher
approved these changes
Sep 29, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tests in #50833 that started failing (3 of them hanging) when we ingested runtime updates, specifically this change dotnet/runtime#90253
We were blocking the send task, by blocking the request content, which is now being waited on in dispose. You could argue that dispose should timeout the send/receive tasks so that hanging
HttpContenttypes can at least observe cancellation to try and unblock. See dotnet/runtime#92390 where that is brought up.