Skip to content

[release/8.0] Update SDK version #50734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release/8.0] Update SDK version #50734

wants to merge 1 commit into from

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Sep 15, 2023

No description provided.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 15, 2023
@jjonescz jjonescz changed the base branch from main to release/8.0 September 15, 2023 14:28
@jjonescz jjonescz mentioned this pull request Sep 18, 2023
Merged
@halter73
Copy link
Member

halter73 commented Sep 19, 2023

Is there a reason this is currently a draft? Should the build ops person be doing any global.json updates outside of main?

@jjonescz
Copy link
Member Author

jjonescz commented Sep 19, 2023 •
edited
Loading

Is there a reason this is currently a draft?

I don't know about your processes of updating SDK. I just inserted the latest Razor compiler changes to see whether anything breaks - and hey, it did... Fixing that in dotnet/razor#9296.

Should the build ops person be doing any global.json updates outside of main?

aspnetcore is currently released from release/8.0 so you should be inserting new SDK 8.0.1xx versions to verify everything still works, I think. This Razor change is an example - currently you don't have the @formname/@rendermode compiler support here, but it will be present in the released SDK, so that's inconsistent.

And btw, you're not getting the Razor changes (and probably others) in 9.0.1xxx SDK I think (that's why your PR #50801 is succeeding unlike this one) - seems that SDK doesn't flow into installer main since Aug 15: dotnet/installer#17187.

@jjonescz jjonescz changed the title Update SDK version [release/8.0] Update SDK version Sep 19, 2023
@jjonescz jjonescz force-pushed the update-sdk branch 2 times, most recently from 48b83cb to 045e0a1 Compare September 22, 2023 11:35
@SteveSandersonMS SteveSandersonMS mentioned this pull request Sep 26, 2023
Closed
@amcasey
Copy link
Member

amcasey commented Dec 8, 2023

@jjonescz Can I close this?

@jjonescz jjonescz closed this Dec 11, 2023
@jjonescz jjonescz deleted the update-sdk branch December 11, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe will be requested when the pull request is marked ready for review wtgodbe is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjonescz @halter73 @amcasey