Skip to content

Conversation

@GeorgiPopovIT
Copy link
Contributor

I think it's a simple and clearer expression.

@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Thanks for your PR, @GeorgiPopovIT. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost
Copy link

ghost commented Sep 23, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 23, 2023
@Tratcher
Copy link
Member

@GeorgiPopovIT, the compiler disagrees with one of these changes 😀. Can you fix or revert that part?

Note we don't normally accept PRs that only change code style.

@GeorgiPopovIT
Copy link
Contributor Author

@Tratcher, thanks for feedback.

@Tratcher Tratcher enabled auto-merge (squash) September 27, 2023 16:57
@Tratcher Tratcher merged commit f0ca75d into dotnet:main Sep 27, 2023
@ghost ghost added this to the 9.0-preview1 milestone Sep 27, 2023
@GeorgiPopovIT
Copy link
Contributor Author

@Tratcher thank you for your code review!

@ghost
Copy link

ghost commented Sep 28, 2023

Hi @GeorgiPopovIT. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@GeorgiPopovIT GeorgiPopovIT deleted the gorges branch November 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants