Skip to content

Remove reflection from KestrelServer constructor #50272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Remove reflection from KestrelServer constructor #50272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
377305c
Remove reflection from KestrelServer constructor
halter73 Aug 22, 2023
7d46e3a
Update src/Servers/Kestrel/Core/src/KestrelServer.cs
halter73 Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/Servers/Kestrel/Core/src/KestrelServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public KestrelServer(IOptions<KestrelServerOptions> options, IConnectionListener
options,
new[] { transportFactory ?? throw new ArgumentNullException(nameof(transportFactory)) },
Array.Empty<IMultiplexedConnectionListenerFactory>(),
new SimpleHttpsConfigurationService(loggerFactory),
new SimpleHttpsConfigurationService(),
loggerFactory,
new KestrelMetrics(new DummyMeterFactory()));
}
Expand Down Expand Up @@ -77,13 +77,6 @@ public void Dispose() { }

private sealed class SimpleHttpsConfigurationService : IHttpsConfigurationService
{
private readonly ILogger<HttpsConnectionMiddleware> _httpsLogger;

public SimpleHttpsConfigurationService(ILoggerFactory loggerFactory)
{
_httpsLogger = loggerFactory.CreateLogger<HttpsConnectionMiddleware>();
}

public bool IsInitialized => true;

public void Initialize(IHostEnvironment hostEnvironment, ILogger<KestrelServer> serverLogger, ILogger<HttpsConnectionMiddleware> httpsLogger)
Expand All @@ -93,7 +86,7 @@ public void Initialize(IHostEnvironment hostEnvironment, ILogger<KestrelServer>

public void PopulateMultiplexedTransportFeatures(FeatureCollection features, ListenOptions listenOptions)
{
HttpsConfigurationService.PopulateMultiplexedTransportFeaturesWorker(features, listenOptions, _httpsLogger);
throw new NotImplementedException(); // Not actually required by this impl, which never provides an IMultiplexedConnectionListenerFactory
}

public ListenOptions UseHttpsWithDefaults(ListenOptions listenOptions)
Expand Down