[SignalR] Error if multiple service attributes are on a single parameter #50248
+84
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benjaminpetit
approved these changes
Aug 23, 2023
| { | ||
| if (marked) | ||
| { | ||
| throw new InvalidOperationException( |
Member
There was a problem hiding this comment.
Maybe we should unify this with the exceptions throw in MVC/minimal APIs?
RE:
Member
Author
There was a problem hiding this comment.
That one doesn't mention which method is the culprit, maybe because it can be an unnamed delegate?
I'd like to keep the name for SignalR so it's very clear where the issue is. Maybe just add it at the beginning:
"{methodExecutor.MethodInfo.FullName}: The {nameof(FromKeyedServicesAttribute)} is not supported on parameters that are also annotated with {nameof(IFromServiceMetadata)}."
Member
Author
There was a problem hiding this comment.
Updated the exception message
captainsafia
approved these changes
Sep 1, 2023
adityamandaleeka
approved these changes
Sep 3, 2023
Member
|
LGTM, is it ready for merge? |
Member
Author
|
Yeah |
ghost
modified the milestone:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also throw if the
ServiceProviderdoesn't support keyed services.Recommend reviewing with whitespace hidden: https://github.com/dotnet/aspnetcore/pull/50248/files?diff=split&w=1