Consume IHostEnvironment.ContentRootFileProvider from CertificatePathWatcher #50246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Watcher We shouldn't be constructing our own `PhysicalFileProvider`s in case the user is abstracting away the file system (e.g. for testing). This simplifies a bunch of things, because there's no exactly one file provider, but we lose the ability to watch certificates outside the content root (which is probably more consistent with our design anyway).
ghost
added
the
amcasey
added
area-networking
Member
Author
|
Customers want to use certs from outside their content root. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be constructing our own
PhysicalFileProviders in case the user is abstracting away the file system (e.g. for testing).This simplifies a bunch of things, because there's no exactly one file provider, but we lose the ability to watch certificates outside the content root (which is probably more consistent with our design anyway).
Follow-up to #49979.