Make stdout/stderr redirection thread timeout configurable #49942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
BrennanConroy,
JamesNK,
Tratcher,
halter73 and
mgravell
as code owners
ghost
added
the
1 task
BrennanConroy
approved these changes
Aug 9, 2023
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Sad we couldn't restructure it. Let's make sure we have an issue for 9 😃
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #45066
The StandardStreamRedirection logic in ANCM uses
CancelSynchronousIoto kick the redirection thread out of its blockingReadFilecall and waits a hardcoded 2 seconds to allow the thread to exit before it callsTerminateThreadon the thread. This works reasonably well in the vast majority of cases (most of the time, the 2 seconds is enough), but occasionally, we have to resort to theTerminateThreadand in a small number of those cases, the thread might be doing something dangerous like holding the OS loader lock.I'd like to eventually rewrite this whole mechanism to eliminate
TerminateThreadentirely (as I did in the file watcher in #49696) but given where we are in the .NET 8 schedule, it's important to minimize the risk involved. This change just makes the timeout for thread termination configurable, so that people who are running into issues with this can give the thread more than 2 seconds to exit.@BrennanConroy