Skip to content

Update Nuget reference (by updating CodeAnalysis) #49843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2023
Merged

Update Nuget reference (by updating CodeAnalysis) #49843

merged 2 commits into from
Aug 4, 2023

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Aug 3, 2023

No description provided.

@BrennanConroy BrennanConroy requested review from a team and wtgodbe as code owners August 3, 2023 15:33
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 3, 2023
@ghost
Copy link

ghost commented Aug 3, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Aug 3, 2023 •
edited
Loading

@sharwell Could you explain what a non-local diagnostic is and why this test is failing with that error?

aspnetcore/src/Framework/AspNetCoreAnalyzers/test/RouteHandlers/DetectMismatchedParameterOptionalityTest.cs

Line 167 in da234b9

public async Task MismatchedOptionalityInSeparateSource_CanBeFixed()

Edit: I might understand. We're looking at the consuming code and creating a diagnostic for another file where the type is defined. Should we just set CodeFixTestBehaviors when testing across multiple files?

@BrennanConroy BrennanConroy mentioned this pull request Aug 3, 2023
Open
@BrennanConroy BrennanConroy merged commit 9427854 into main Aug 4, 2023
@BrennanConroy BrennanConroy deleted the BrennanConroy-patch-1 branch August 4, 2023 02:33
@ghost ghost added this to the 8.0-rc1 milestone Aug 4, 2023
sharwell
sharwell reviewed Aug 7, 2023
View reviewed changes
src/Framework/AspNetCoreAnalyzers/test/Verifiers/CSharpCodeFixVerifier.cs
NumberOfFixAllIterations = expectedIterations,
CodeActionEquivalenceKey = codeActionEquivalenceKey
CodeActionEquivalenceKey = codeActionEquivalenceKey,
CodeFixTestBehaviors = CodeFixTestBehaviors.SkipLocalDiagnosticCheck,
Copy link
Contributor

@sharwell sharwell Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This should ideally be applied to specific tests which are impacted by the change. Tests which require this flag represent broken product behavior, and if the value is set for the entire test project there is no way to know what/if anything works.

Copy link
Member Author

@BrennanConroy BrennanConroy Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, filed #49856, please continue discussion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienros sebastienros sebastienros approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

+1 more reviewer

@sharwell sharwell sharwell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

8.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@BrennanConroy @sebastienros @sharwell