Dispose CancellationTokenSource

[alex-inftx]

we can dispose CancellationTokenSource after use

[ghost]

Thanks for your PR, @alex-inftx. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[ghost]

Hi @alex-inftx. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[gfoidl]

@alex-inftx please change the target branch of this PR to be main (and not release/6.0).

[sharwell]

I changed the base branch to main not realizing that release/6.0 hasn't merged into main yet. Sorry for the noise.

[mgravell]

I changed the base branch to main not realizing that release/6.0 hasn't merged into main yet. Sorry for the noise.

Still looks like 6.0 unless I'm misreading; if you click edit, the target branch should become editable:

However, if it starts freaking out, it may be easier to redo the branch against main.

as an aside: there is no "yet" here - 6.0 is a maintenance branch; it'll stay independent until some future hypothetical point when it simply gets nuked

[sebastienros]

I changed the base branch but now there are lots of conflicts. Might be easier to create a new PR.

[mgravell]

yeah, that would be the "freaking out" I was hoping to avoid :) in theory it should be possible to rebase and force push, but for a 2 line change, starting a clean branch from main is probably much much simpler

[ghost]

Hi @alex-inftx. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[alex-inftx]

@alex-inftx please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="infotecs"

[alex-inftx]

yeah, that would be the "freaking out" I was hoping to avoid :) in theory it should be possible to rebase and force push, but for a 2 line change, starting a clean branch from main is probably much much simpler

It's done [rebase and+force push] )

[mgravell]

This looks good to me, and should clean up a timer callback 👍

[alex-inftx]

This looks good to me, and should clean up a timer callback 👍
thank you!
@mgravell , should I create a new PRs to place changes to release/6.0 and release/7.0 ?

[mgravell]

@alex-inftx IMO no this doesn't warrant backport. Yes, it may be more efficient, but: the feature isn't fundamentally broken or dangerous "as is". Others may disagree, but I vote "no"

[adityamandaleeka]

Thanks @alex-inftx. I agree with @mgravell that this doesn't need to be backported.