Update SDK to 8.0.100-rc.1.23381.2 #49761

eerhardt · 2023-07-31T18:10:55Z

Testing for dotnet/runtime#89734. Trying to see if we can repro the issue.

eerhardt · 2023-07-31T18:17:18Z

@lewing @radical @javiercn - Looks like everything is failing with

/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]

Can someone fix it?

javiercn · 2023-07-31T18:22:37Z

@eerhardt did this fail on retry?

eerhardt · 2023-07-31T18:24:26Z

@eerhardt did this fail on retry?

This is failing every leg. Check the build logs.

lewing · 2023-07-31T18:28:06Z

@radical can you take a look?

radical · 2023-07-31T18:40:55Z

I'm looking at the workload issue. But there are other errors too:

/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj::TargetFramework=net8.0]
/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj::TargetFramework=net462]
/Users/runner/work/1/s/src/Caching/SqlServer/src/SqlServerCache.cs(62,19): error CA2208: Method .ctor passes 'DefaultSlidingExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj]
/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/RedisCache.cs(576,19): error CA2208: Method GetAbsoluteExpiration passes 'AbsoluteExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/RedisCache.cs(576,19): error CA2208: Method GetAbsoluteExpiration passes 'AbsoluteExpiration' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj]
/Users/runner/work/1/s/src/Components/Components/src/Routing/TemplateSegment.cs(96,17): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj]
/Users/runner/work/1/s/src/Components/Components/src/Routing/TemplateSegment.cs(26,41): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-dev-certs/src/dotnet-dev-certs.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-user-jwts/src/dotnet-user-jwts.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/dotnet-user-secrets/src/dotnet-user-secrets.csproj]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj::TargetFramework=netcoreapp2.1]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(42,19): error CA2208: Method .ctor passes 'BatchSize' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs(46,19): error CA2208: Method .ctor passes 'FlushPeriod' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208) [/Users/runner/work/1/s/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj::TargetFramework=netstandard2.0]
/Users/runner/work/1/s/src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs(29,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj::TargetFramework=net8.0]
/Users/runner/work/1/s/src/Http/Routing/src/Patterns/RoutePatternParser.cs(444,13): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(125,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(126,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(132,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]
/Users/runner/work/1/s/src/Http/Http/src/Internal/ResponseCookies.cs(138,21): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/Users/runner/work/1/s/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj]

/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]

eerhardt · 2023-07-31T19:14:07Z

But there are other errors too:

yeah, I'm fixing those

src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs

Issue when updating to build with rc1: ``` /Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj] /Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj] ``` Explanation: 1. This project has `RuntimeIdentifier=browser-wasm`, which triggers the workload manifests for wasm 2. But the project is *not* using blazor sdk, or the wasm-sdk. 3. The condition at https://github.com/dotnet/emsdk/blob/5466de081d350d3214c1ae68b7fca6295109d5cf/eng/nuget/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.targets#L12 ```xml <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true' or '$(UsingMicrosoftNETSdkWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> ``` .. means that if a `rid=browser-wasm` project is not using blazor sdk, or the wasm sdk, then it depends on the targets in the workload. And hence requires the workload. Solution: As a workaround set `UsingMicrosoftNETSdkWebAssembly=true` also (`UsingMicrosoftNETSdkBlazorWebAssembly` is already set to true).

…ensions.cs" This reverts commit e36a692.

Update SDK to 8.0.100-rc.1.23381.2

a56ab32

eerhardt requested review from a team and wtgodbe as code owners July 31, 2023 18:10

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 31, 2023

Respond to new code analysis warnings.

048f67d

eerhardt requested review from a team, BrennanConroy, Tratcher, captainsafia, halter73, javiercn and mgravell as code owners July 31, 2023 19:28

Fix up previous changes

b15ee03

eerhardt force-pushed the UpdateSDK branch from 454b3e4 to b15ee03 Compare July 31, 2023 19:49

BrennanConroy reviewed Jul 31, 2023

View reviewed changes

src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs Outdated Show resolved Hide resolved

BrennanConroy and others added 6 commits July 31, 2023 13:12

Update src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs

e36a692

Revert "Update src/Tools/Shared/CommandLine/CommandLineApplicationExt…

39299e0

…ensions.cs" This reverts commit e36a692.

Fix build on non-.NET Core.

17ac0eb

More fixes.

d6872c4

Fix ViewPath

0e5f826

eerhardt requested a review from a team as a code owner July 31, 2023 21:54

sebastienros approved these changes Jul 31, 2023

View reviewed changes

eerhardt merged commit 94f1088 into dotnet:main Jul 31, 2023

eerhardt deleted the UpdateSDK branch July 31, 2023 23:33

ghost added this to the 8.0-rc1 milestone Jul 31, 2023

This was referenced Jul 31, 2023

ASP.NET CI Broken on Linux ARM and Linux musl-x64 dotnet/runtime#89734

Closed

Revert "Reverting SDK (#49709)" #49763

Closed

This was referenced Aug 2, 2023

Missing workload check causes error for WasmLinkerTest project #49774

Closed

Revert "aspnetcore patch to exclude WasmLinkerTest project from build" dotnet/installer#17122

Merged

halter73 mentioned this pull request Aug 8, 2023

Update SDK to 9.0.100-alpha.1.23421.9 #49911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update SDK to 8.0.100-rc.1.23381.2 #49761

Update SDK to 8.0.100-rc.1.23381.2 #49761

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

javiercn commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

lewing commented Jul 31, 2023

Uh oh!

radical commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Update SDK to 8.0.100-rc.1.23381.2 #49761

Update SDK to 8.0.100-rc.1.23381.2 #49761

Uh oh!

Conversation

eerhardt commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

javiercn commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

lewing commented Jul 31, 2023

Uh oh!

radical commented Jul 31, 2023

Uh oh!

eerhardt commented Jul 31, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants