Skip to content

Use SearchValues in HostString #49114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

Use SearchValues in HostString #49114

merged 1 commit into from
Jul 6, 2023

Conversation

@MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Jun 30, 2023

  • Use SearchValues instead of a loop around IsSafeHostStringChar
  • Avoid allocating new IdnMapping instances every time
  • Avoid some temporary substring allocations

Contributes to #46484

@ghost ghost added the area-runtime label Jun 30, 2023
@mitchdenny mitchdenny mentioned this pull request Jul 3, 2023
Merged
@MihaZupan
Copy link
Member Author

MihaZupan commented Jul 5, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2023

Azure Pipelines successfully started running 3 pipeline(s).

@Tratcher Tratcher merged commit 51c1ada into dotnet:main Jul 6, 2023
@ghost ghost added this to the 8.0-preview7 milestone Jul 6, 2023
@Tratcher
Copy link
Member

Tratcher commented Jul 6, 2023

Thanks

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Perf

Projects

None yet

Milestone

8.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@MihaZupan @Tratcher @BrennanConroy @amcasey