Allow non-NetFramework tests to be skipped with Mono

[david-acker]

Allow non-NetFramework tests to be skipped on Mono

Updates the FrameworkSkipConditionAttribute to allow for non-NetFramework tests to be skipped with Mono runtime.

Fixes #48688

[ghost]

Thanks for your PR, @david-acker. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[danmoseley]

just curious, any particular reason this exists rather than reusing the ones in the shared toolset --
https://github.com/dotnet/arcade/tree/792c346a52b2388152c2fad6f626b88ed8736d6f/src/Microsoft.DotNet.XUnitExtensions/src/Attributes

eg [SkipOnMonoAttribute] [PlatformSpecific(TestPlatforms.Windows | TestPlatforms.OSX)]

[david-acker]

Interesting... I'm not sure personally. It looks like FrameworkSkipConditionAttribute slightly predates SkipOnMonoAttribute though, based on the commit history.

@wtgodbe Do you know of any reasons why we aren't using the attributes from the shared toolset?

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[wtgodbe]

@wtgodbe Do you know of any reasons why we aren't using the attributes from the shared toolset?

No strong reason, we created our own xunit attributes a long time ago and never bothered migrating to the shared ones when they got rolled out. It's something we'd do if we had more resources, but isn't urgent enough to be prioritized right now.