Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 11, 2023

This PR removes route and method tags from rate-limiting metrics.

Three reasons:

  • Route information isn't specific to rate limiting. It doesn't fit (unless we decide that all asp.net core metrics should have this information).
  • Rate limiting has a policy name to identify rate-limiting metrics. For example, you can see a count of queued requests against a policy name.
  • We can add route tags back in the future if there is feedback that it's wanted.

@JamesNK JamesNK added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 11, 2023
@ghost ghost added the area-runtime label Jun 11, 2023
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@JamesNK JamesNK merged commit f1da7a0 into main Jun 20, 2023
@JamesNK JamesNK deleted the jamesnk/ratelimiting-remove-route branch June 20, 2023 00:47
@ghost ghost added this to the 8.0-preview6 milestone Jun 20, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants