Skip to content

Sections with other features #48518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 20, 2023
Merged

Sections with other features #48518

merged 16 commits into from
Jun 20, 2023

Conversation

@surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented May 30, 2023 •
edited
Loading

Sections with other features

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

See API Proposal for complete description.

Fixes #47621

@surayya-MS surayya-MS requested a review from a team as a code owner May 30, 2023 16:27
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label May 30, 2023
@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jun 13, 2023

@surayya-MS Thanks for the reminder about this. I'm looking through it now.

SteveSandersonMS
SteveSandersonMS approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is a tricky area so I'm really glad you were able to figure out all the details. And the simplified implementation of sections (eliminating various internal interfaces) is much cleaner too.

@surayya-MS surayya-MS merged commit 6e515a2 into dotnet:main Jun 20, 2023
@ghost ghost added this to the 8.0-preview6 milestone Jun 20, 2023
@surayya-MS surayya-MS deleted the sectionsOtherFeatures branch June 20, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

8.0-preview6

Development

Successfully merging this pull request may close these issues.

Ensure other features interact well with Sections

3 participants

@surayya-MS @SteveSandersonMS @javiercn