Remove __non_webpack_require__ workaround and split Node dependencies correctly #48154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
ghost
added
the
pending-ci-rerun
mitchdenny
approved these changes
Jul 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47674
Removed
__non_webpack_require__usage and replaced it with thebrowserfield in package.json. And moved the dynamic require code into a swappable file. This allows us to tell bundlers not to include the external dependencies as well as provide noop/error methods in case we ever accidentally call the dynamic requires in the browser.Tested with esbuild and an angular app.
Verified angular app doesn't include external dependencies that we use for Node in the browser
Verified esbuild calls
require_*and includes external dependencies in bundle.Verified signalr.min.js stays at 43kb.