[Blazor] Specialize pipeline for MapRazorComponents #47649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current pipeline is common for MapRazorComponents and RazorComponentResults which add extra complexity to MapRazorComponents which we expect to be the common case. The change splits the pipeline in two, so that we can simplify the pipeline for MapRazorComponents, where we can make assumptions that are not possible in RazorComponentResult. This change introduces RazorComponentEndpointInvoker to capture all the required state that is needed for rendering the component endpoint and avoid additional closures from captured state caused by calling Dispatcher.InvokeAsync. We also guarantee that we only call `DispatchAsync` once at the root level to enter the synchronization context. Finally, we skip over all the render modes and preserve prerendered component state mode update, since that's not needed at this level.
ghost
added
the
MackinnonBuck
approved these changes
Apr 13, 2023
Member
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
Just a small question but looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pipeline is common for MapRazorComponents and RazorComponentResults which add extra complexity to MapRazorComponents which we expect to be the common case.
The change splits the pipeline in two, so that we can simplify the pipeline for MapRazorComponents, where we can make assumptions that are not possible in RazorComponentResult.
This change introduces RazorComponentEndpointInvoker to capture all the required state that is needed for rendering the component endpoint and avoid additional closures from captured state caused by calling Dispatcher.InvokeAsync.
We also guarantee that we only call
DispatchAsynconce at the root level to enter the synchronization context.Finally, we skip over all the render modes and preserve prerendered component state mode update, since that's not needed at this level.