-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/7.0] Fix verb in route template with gRPC transcoding #47162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Note: Includes changes from #47165 (discovered while doing manual testing) |
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
@wtgodbe to confirm with James on confidence of the fix. Last day for checking in and we don't want to elevate risk. |
|
If confidence in risk is "very high" we're OK taking this today for next month. If it's not quite that high, please check in after branch reopens for subsequent servicing release |
|
Ok, can delay it to 7.0.6. |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
To confirm, 7.0.6 is slated for May, meaning we expect to merge this in early April (when branches open), right? |
Yes |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Backport of #47123 to release/7.0
/cc @JamesNK
Fix verb in route template with gRPC transcoding
gRPC JSON transcoding routes can have a "verb" at the end of the route. It's indicated by a colon. For example:
/v1/greeter/{name}:calculate. It's used for the custom method pattern.The verb was incorrectly not being used when creating ASP.NET Core endpoints. The result is routing errors. For example,
/v1/frames:startand/v1/frames:getboth end up with a route/v1/frames, which creates an ambiguous match exception.Fixes grpc/grpc-dotnet#2054
Customer Impact
Reported by a customer at grpc/grpc-dotnet#2054. They have an error and there isn't a good workaround. Routes could be changed to not use a verb, but forcing developers to change their API address and calling clients isn't good.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Change only impacts gRPC JSON transcoding, and only if someone is using verb in route.
Verification
Packaging changes reviewed?
When servicing release/2.1