Update template spelling and wording #46886
Conversation
dougbu
commented
Feb 25, 2023
dougbu
commented
- follow up to Add 'dotnet new' web item templates (razor view, api controller, mvc controller) #46714
- align template.json and templatestrings.en.json files
- correct 'ReadWrite' and 'Am'
- build to create localized template files
- good to do this whenever we create new templates
dougbu
requested review from
DamianEdwards,
MackinnonBuck,
Nick-Stanton,
deepchoudhery,
javiercn,
mkArtakMSFT,
sayedihashimi and
vijayrkn
ghost
added
the
area-mvc
|
Noticed a few issues when glancing at #46882. The changes contain a few comments for reviewers. Though I used loc comment syntax (start w/ an underscore and end w/ ".comment"), the comments are not intended to be merged. |
|
It would be great to have @phenning to review the template related updates here. |
phenning
left a comment
phenning
left a comment
There was a problem hiding this comment.
From a Visual Studio perspective, LGTM. Note that we don't surface any of the item template metadata directly in VIsual Studio as of now anyway, as we still use the vstemplate -> template engine pattern rather than exposing the sdk template directly in the new item dialog.
src/ProjectTemplates/Web.ItemTemplates/content/ApiController/.template.config/template.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/MvcController/.template.config/template.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/RazorView/.template.config/template.json
Outdated
Show resolved
Hide resolved
|
/fyi The Arcade SDK adds a Microsoft.TemplateEngine.Authoring.Tasks package reference in all projects. That detects template.json files and propagate the strings into localize/templatestrings.*.json files. |
...es/Web.ItemTemplates/content/ApiController/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
...es/Web.ItemTemplates/content/ApiController/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
|
What are your thoughts on the questions I placed in the templatestrings.en.json files @mkArtakMSFT❔ (Not merging this w/o at least removing those comments.) |
mkArtakMSFT
left a comment
mkArtakMSFT
left a comment
There was a problem hiding this comment.
Answered your questions
...plates/Web.ItemTemplates/content/RazorView/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
...es/Web.ItemTemplates/content/MvcController/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
- follow up to #46714 - align template.json and templatestrings.en.json files - correct 'ReadWrite' and 'Am' - ask a few questions of reviewers
- no need to change post-action `description`s
- remove comment nodes from templatestrings.en.json files - also, update English resources to match template.json content
- fill in missed files in localize/ folder
5 participants
