Skip to content

Update sourceIndexPackageVersion #45982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Update sourceIndexPackageVersion #45982

merged 1 commit into from
Jan 10, 2023

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 9, 2023 •
edited
Loading

Fixing the official build break introduced by #45879. We can't get rid of these SourceIndex properties and use the arcade defaults, because these are used directly later in this file.

@wtgodbe wtgodbe requested review from a team and dougbu as code owners January 9, 2023 23:20
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2023
@wtgodbe wtgodbe mentioned this pull request Jan 9, 2023
Merged
dougbu
dougbu approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what happens w/ official builds once this goes in. Are you pretty sure this package version contains the changes we need to support newer binary logs❔

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 10, 2023

Yeah, this is the one Matt claims fixes the issue in dotnet/arcade#11995

@wtgodbe wtgodbe merged commit 351d34b into main Jan 10, 2023
@wtgodbe wtgodbe deleted the wtgodbe/SourceIndex branch January 10, 2023 00:39
@ghost ghost added this to the 8.0-preview1 milestone Jan 10, 2023
@wtgodbe wtgodbe mentioned this pull request Feb 28, 2023
Closed
@mitchdenny mitchdenny mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

+1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @mitchdenny @dougbu