Unset MicrosoftNetCompilersToolsetVersion #45881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
wtgodbe
commented
Jan 4, 2023
| if (completionMessage.HasResult) | ||
| { | ||
| tcs.SetResult((T)completionMessage.Result); | ||
| tcs.SetResult((T)completionMessage.Result!); |
There was a problem hiding this comment.
CC @BrennanConroy this is to preemptively fix dotnet/installer#15151 (comment), which we'll see once we ingest the new SDK from that PR
| var result = _pendingInvocations.TryAdd(invocationId, (typeof(T), connectionId, tcs, static (state, completionMessage) => | ||
| { | ||
| var tcs = (TaskCompletionSourceWithCancellation<T>)state; | ||
| if (completionMessage.HasResult) |
There was a problem hiding this comment.
No, Result is allowed to be null, the issue is using generics and nullability doesn't play nicely together.
BrennanConroy
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is older than what's in Arcade now: https://github.com/dotnet/arcade/blob/eae015fb1c92ceef69126164b3969447d0355c08/eng/Versions.props#L45. dotnet/SDK uses the Arcade version, so we can just fall back to that.
Fixes #45882