Skip to content

Conversation

@captainsafia
Copy link
Member

Closes #45542

cc: @marcominerva

@captainsafia captainsafia requested a review from a team as a code owner December 13, 2022 19:30
@ghost ghost added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Dec 13, 2022
@captainsafia captainsafia merged commit 0ee6bca into main Dec 14, 2022
@captainsafia captainsafia deleted the safia/openapi-param-attrs branch December 14, 2022 01:22
@ghost ghost added this to the 8.0-preview1 milestone Dec 14, 2022
@captainsafia
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3690856149

@github-actions
Copy link
Contributor

@captainsafia backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix support for parameter names sourced from attributes
Using index info to reconstruct a base tree...
M	src/OpenApi/src/OpenApiGenerator.cs
M	src/OpenApi/test/OpenApiGeneratorTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/OpenApi/test/OpenApiGeneratorTests.cs
Auto-merging src/OpenApi/src/OpenApiGenerator.cs
CONFLICT (content): Merge conflict in src/OpenApi/src/OpenApiGenerator.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix support for parameter names sourced from attributes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@captainsafia an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Minimal API] Route, Query and Header parameter names are ignored when using WithOpenApi extension method

3 participants