[main] Use new Arm64 Helix queues #44868
Conversation
ghost
added
the
area-infrastructure
nit: Change `$(IsXYZQueue)` properties to ignore case - removes one gotcha going forward
- use `dotnet` to avoid x64 requirements when using Win11 ARM64
|
Checking out the changes, it all looks good but it seems like an ARM64 Windows run didn't happen? |
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
windows.11.arm64.open is getting .sh files for runtests in the linked run
| <IsArm64HelixQueue>$(HelixTargetQueue.Contains('Arm64'))</IsArm64HelixQueue> | ||
| <IsWindowsHelixQueue>$(HelixTargetQueue.Contains('Windows'))</IsWindowsHelixQueue> | ||
| <IsMacHelixQueue>$(HelixTargetQueue.Contains('OSX'))</IsMacHelixQueue> | ||
| <IsArm64HelixQueue>$(HelixTargetQueue.ToUpperInvariant().Contains('ARM64'))</IsArm64HelixQueue> |
There was a problem hiding this comment.
this should be "or ARMARCH"... or just ARM since we're getting rid of the last ARM32s
There was a problem hiding this comment.
No, call runtests.cmd AuthSamples.FunctionalTests.dll 8.0.0-ci windows.11.arm64.open arm64 false 00:45:00 false is right at the top of the latest aspnetcore-helix-matrix run for this PR. The Win11 arm64 tests only run in that pipeline and I kicked it off manually.
This line works fine for the current Win11 build as well as Debian.11.Arm64.Open though the underlying image (Ubuntu.1804.Armarch.Open) wouldn't match. I think we're fine until / unless we update that friendly name or move to a Win11 queue using armarch.
There was a problem hiding this comment.
However, I did have a bug in a previous iteration which caused runtests.sh to be used. That's why I added the ToUpperInvariant() calls.
3 participants
nit: Change
$(IsXYZQueue)properties to ignore case