Skip to content

Fix request delegate analyzer error on null return type #44534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix request delegate analyzer error on null return type #44534

merged 1 commit into from
Oct 14, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 14, 2022

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 14, 2022
@JamesNK JamesNK added area-runtime old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Oct 14, 2022
@JamesNK JamesNK merged commit 0cfd468 into main Oct 14, 2022
@JamesNK JamesNK deleted the jamesnk/requestdelegate-analyzer-nre branch October 14, 2022 05:21
@ghost ghost added this to the 8.0-preview1 milestone Oct 14, 2022
kasperk81
kasperk81 reviewed Oct 18, 2022
View reviewed changes
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Http/RequestDelegateReturnTypeAnalyzer.cs
returnOperation.ReturnedValue is { } returnedValue)
{
var resolvedOperation = WalkDownConversion(returnedValue);
var returnType = resolvedOperation.Type;
Copy link
Contributor

@kasperk81 kasperk81 Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is still failing, maybe this will fix it:

Suggested change
var returnType = resolvedOperation.Type;
var returnType = resolvedOperation?.Type;

@kasperk81 kasperk81 mentioned this pull request Oct 18, 2022
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunolins16 brunolins16 brunolins16 approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia

@halter73 halter73 Awaiting requested review from halter73

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

+1 more reviewer

@kasperk81 kasperk81 kasperk81 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

8 participants

@JamesNK @brunolins16 @kasperk81 @halter73 @captainsafia @BrennanConroy @amcasey