Write manual Parallel.For to await test result #44528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
JamesNK,
Tratcher and
halter73
as code owners
Tratcher
approved these changes
Oct 13, 2022
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the
TraceIdentifierIsUniquetest failed on CI, see a previous failure #21118.Decided to take a look, noticed that we were using
Parallel.Forwith an async action (which is basicallyasync void). My hypothesis is that theParallel.Foractions could still be running while the test method completes and closes the server, resulting in errors on the background thread.Ran the test 10000 times before: reproduced the failure
Ran the test 20000 times after: did not get any failures