Don't package Microsoft.Aspnetcore.Ratelimiting #44501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
wtgodbe
added
Servicing-consider
|
Hi @wtgodbe. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
dougbu
approved these changes
Oct 12, 2022
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Was this project packable originally because we decided to put it in the shared framework and didn't reconsider the package❔
Member
Author
Yeah, at first it was package-only. When we put it in the SharedFx, we didn't also make it non-packable. |
wtgodbe
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't package Microsoft.Aspnetcore.Ratelimiting
Only ship Microsoft.Aspnetcore.Ratelimiting in the Shared Framework
Description
Turns off the package build for Microsoft.Aspnetcore.Ratelimiting so that it only ships via the Shared Framework
Customer Impact
Eliminates confusion over how to ingest Microsoft.Aspnetcore.Ratelimiting
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
People consuming this via a package would already have needed to use our SharedFx as well, so they shouldn't be broken by this.
Verification
Packaging changes reviewed?
When servicing release/2.1