Quarantine OutputFlowControl_ConnectionAndRequestAborted_NoException #44417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
BrennanConroy,
JamesNK and
Tratcher
as code owners
ghost
added
the
|
How often does the deadlock occur? If it's not very frequent, I think quarantining is fine, otherwise I'd lean towards disabling the test entirely. |
|
This is my first time seeing it, but it's not like I'm always looking at test hangs on helix. |
BrennanConroy
approved these changes
Oct 7, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44415
OutputFlowControl_ConnectionAndRequestAborted_NoExceptioninduced a deadlock that caused the entire InMemory.FunctionalTests Helix work item to hang.I share my analysis in the issue. I think this deadlock can only happen in our tests. We could try doing less inline in Kestrel's in-memory HTTP/2 tests which would be more real-world, but it would require fixing our tests in reaction to new possible delays. It would be moving the opposite direction I was trying to go in with #41181, but maybe that's a lost cause. @JamesNK @davidfowl
@dougbu @wtgodbe Is quarantining the right move for a test that can rarely lead to deadlocks? Not much has changed in this area in the last few months. This is the only test I've seen it happen with, but there could be others.