Skip to content

Upgrade Microsoft.OpenApi dependency to 1.4.3 #44229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2022
Merged

Upgrade Microsoft.OpenApi dependency to 1.4.3 #44229

merged 2 commits into from
Sep 29, 2022

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 28, 2022

Description

This PR upgrades our Microssoft.OpenApi dependency to 1.4.3 to capture bug fixes and features.

Customer Impact

Users will have access to bug fixes for the copy-constructors on their OpenApiOperation definitions and improvements to the accuracy of the generated OpenAPI document.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Impact is isolated to Microsoft.AspNetCore.OpenApi package.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@captainsafia captainsafia added Servicing-consider Shiproom approval is required for the issue old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Sep 28, 2022
@captainsafia captainsafia requested review from a team, dougbu and wtgodbe as code owners September 28, 2022 17:01
@captainsafia captainsafia requested a review from a team September 28, 2022 17:03
@ghost
Copy link

ghost commented Sep 28, 2022

Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 28, 2022
halter73
halter73 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can now write a test that uses the OpenApiOperation copy constructor?

@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 29, 2022
@rbhanda rbhanda added this to the 7.0.0 milestone Sep 29, 2022
@captainsafia
Copy link
Member Author

captainsafia commented Sep 29, 2022

Does this mean we can now write a test that uses the OpenApiOperation copy constructor?

Yep! I update some of our tests to use copy constructors.

@captainsafia
Copy link
Member Author

captainsafia commented Sep 29, 2022

@dotnet/aspnet-admins Can I get help merging this?

@dougbu dougbu merged commit 11c390d into release/7.0 Sep 29, 2022
@dougbu dougbu deleted the safia/bump-msopenapi-dep branch September 29, 2022 22:08
@captainsafia captainsafia mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

+1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Servicing-approved Shiproom has approved the issue

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@captainsafia @halter73 @dougbu @wtgodbe @rbhanda