Only add MethodInfo to route handler endpoints #44021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
captainsafia
added
the
old-area-web-frameworks-do-not-use
Member
Author
|
@Pilchie Any chance we can get this in for RC2? We'd like to react to some user feedback we got from RC1. |
Member
|
Here's the breaking change announcement for RC1: aspnet/Announcements#493 |
halter73
approved these changes
Sep 15, 2022
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I agree we should revert this breaking behavioral change for RC2.
captainsafia
added
the
Servicing-consider
|
Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
halter73
added
Servicing-approved
Member
|
This has been approved by tactics @dotnet/aspnet-build. |
Contributor
|
Alright @halter73, will merge. Please use |
Contributor
|
(oops, edited out a typo above) |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a regression to OpenAPI-generation behavior due to a change in the
RouteEndpointDataSourcethat was introduced in RC1. See this comment for more einfo.Fixes #44005
Customer Impact
This PR resolves a regression in which endpoints that customers would expect to be hidden from OpenAPI generation were visible
Regression?
This is a regression from .NET 6 and .NET 7 Preview 7 behavior.
Risk
The risk is low because we are reverting to known behavior (as of .NET 6).
Verification
Packaging changes reviewed?