Follow-up for cancellation of navigation events in Blazor #43079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
campersau
reviewed
Aug 3, 2022
MackinnonBuck
commented
Aug 3, 2022
Co-authored-by: campersau <[email protected]>
MackinnonBuck
commented
Aug 3, 2022
halter73
approved these changes
Aug 3, 2022
SteveSandersonMS
approved these changes
Aug 4, 2022
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Nice one!
I added a couple of minor suggestions but besides that I think this feature looks all wrapped up :)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for cancellation of navigation events in Blazor
This PR applies the changes discussed in the API review issue #42877.
Description
Functionality remains almost completely the same as it did before, but now the API has changed in accordance with the API review for this feature. I'll point out any differences in behavior by commenting on this PR.
Fixes #42877