Fix Blazor boot config loading #41976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TanayParikh
reviewed
Jun 1, 2022
Contributor
TanayParikh
left a comment
TanayParikh
left a comment
There was a problem hiding this comment.
Are we planning on backporting this to 6.0?
Member
Author
Yep, I'll create a backport PR after this is merged. |
TanayParikh
approved these changes
Jun 1, 2022
MackinnonBuck
added a commit
that referenced
this pull request
Jun 1, 2022
10 tasks
wtgodbe
pushed a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Blazor boot config loading
There was an
instanceof Promisecheck inBootConfig.tsthat failed when the defaultPromisetype got overridden (as it does in libraries likezone.js). This PR fixes the issue by rearranging the logic to avoid performing this check.The filed issue used Blazor components in an Angular app, where Blazor was manually started using
Blazor.start()rather than letting the script auto-start. I've reproduced original bug and verified the fix locally.Fixes #40245