Skip to content

Conversation

@mkArtakMSFT
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT commented May 31, 2022

Also drop a comment on community contributions suggesting that someone will get assigned to the PR soon and get it reviewed.

Note ⚠️: Because we don't rely on FabricBot UI any more, I am using the Internal: Debug label to validate my new rule. After validation, I'll update this file one more time to remove the condition.

Also drop a comment on community contributions suggesting that someone will get assigned to the PR soon and get it reviewed.

**Note**: Because we don't rely on FabricBot UI any more, I am using the `Internal: Debug` label to validate my new rule. After validation, I'll update this file one more time to remove the condition.
@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 31, 2022
@mkArtakMSFT mkArtakMSFT requested review from a team, Pilchie and dougbu May 31, 2022 17:37
@mkArtakMSFT mkArtakMSFT requested a review from wtgodbe as a code owner May 31, 2022 17:37
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works after removing the Internal: Debug bit, looks good

@mkArtakMSFT
Copy link
Contributor Author

If it works after removing the Internal: Debug bit, looks good

I'll find that out after merging this. And then, when everything is ok, will remove the debug label.

@MackinnonBuck
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mkArtakMSFT mkArtakMSFT merged commit 53855d2 into main May 31, 2022
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT-patch-1 branch May 31, 2022 23:15
@ghost ghost added this to the 7.0-preview6 milestone May 31, 2022
@mkArtakMSFT
Copy link
Contributor Author

I've validated the rule with the debug label in place and have already removed the condition. Here is the verification PR that I've used: #41954

This concludes the changes we've talked about for me to implement.

@dougbu
Copy link
Contributor

dougbu commented Jun 1, 2022

This concludes the changes we've talked about for me to implement.

Doesn't the Internal: Debug label requirement need to be removed now❔

@wtgodbe
Copy link
Member

wtgodbe commented Jun 1, 2022

Also are we going to update codeowners? I'm now getting about 10 emails on each PR I'm tagged on 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants