Skip to content

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Apr 25, 2022

Description

This fixes a bug with IIS where Abort would gracefully close a response instead of aborting it.

Backport of #41263

Customer Impact

Clients could see potentially truncated responses instead of being able to tell that the response was aborted abnormally, this is a form of data corruption.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Abort behavior had a test that slowly got to 0% pass rate due to scheduling changes, this change fixes the test

Verification

  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-runtime label Apr 25, 2022
@ghost ghost added this to the 6.0.x milestone Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

Hi @HaoK. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@HaoK HaoK requested a review from Tratcher April 26, 2022 15:35
@HaoK HaoK marked this pull request as ready for review April 26, 2022 15:35
@HaoK HaoK added the Servicing-consider Shiproom approval is required for the issue label Apr 26, 2022
@ghost
Copy link

ghost commented Apr 26, 2022

Hi @HaoK. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels May 3, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.6 May 3, 2022
@halter73 halter73 merged commit b1d2844 into release/6.0 May 4, 2022
@halter73 halter73 deleted the haok/6.0/abort branch May 4, 2022 22:45
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants