Skip to content

Use handler directly in gRPC interop tests #41251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Use handler directly in gRPC interop tests #41251

merged 1 commit into from
Apr 19, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 18, 2022

Using handler is better than HttpClient because HttpClient adds various timeouts and other features that we don't need/want.

A default channel uses handler so this lines up better with real world. Also, matches how interop tests are run elsewhere.

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Apr 18, 2022
@JamesNK JamesNK requested a review from captainsafia as a code owner April 18, 2022 23:34
@JamesNK JamesNK merged commit 315febe into main Apr 19, 2022
@JamesNK JamesNK deleted the jamesnk/grpcinterop-httphandler branch April 19, 2022 02:00
@ghost ghost added this to the 7.0-preview4 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

No one assigned

Labels

area-grpc Includes: GRPC wire-up, templates

Projects

None yet

Milestone

7.0-preview4

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesNK @davidfowl