-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/3.1] Fix component government bugs #41160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
…tcore into wtgodbe/CompGov412
dougbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't sign off as long as yarn-audit-fix is listed as a dev dependency in any package.json file
Should be fixed |
dougbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can get this building…
|
The build failures are very weird, they started happening after just updating some yarn.lock files, and they're right at the beginning of the build, before we'd be trying to do anything with the .js/.ts stuff:
Gonna try the 1es images |
|
Kestrel tests like
This rings a bell, but I can't find old info about it - @halter73 @BrennanConroy @Tratcher does this look like a machine issue? It looks like these tests were deleted some time in the 5.0 time frame |
|
@Tratcher @BrennanConroy @halter73 @JamesNK any ideas on the above? |
|
The skip conditions have been updated in main. aspnetcore/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs Lines 30 to 31 in 9042085
aspnetcore/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs Lines 25 to 26 in 4918f53
|
Fix (at least) most of the Medium+ release/3.1 CompGov bugs