Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 12, 2022

Fix (at least) most of the Medium+ release/3.1 CompGov bugs

@ghost ghost added this to the 3.1.x milestone Apr 12, 2022
@ghost
Copy link

ghost commented Apr 12, 2022

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 13, 2022
@wtgodbe wtgodbe changed the title Fix component government bugs [release/3.1] Fix component government bugs May 2, 2022
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't sign off as long as yarn-audit-fix is listed as a dev dependency in any package.json file

@wtgodbe
Copy link
Member Author

wtgodbe commented May 3, 2022

I can't sign off as long as yarn-audit-fix is listed as a dev dependency in any package.json file

Should be fixed

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can get this building…

@wtgodbe
Copy link
Member Author

wtgodbe commented May 4, 2022

The build failures are very weird, they started happening after just updating some yarn.lock files, and they're right at the beginning of the build, before we'd be trying to do anything with the .js/.ts stuff:

C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin\amd64\msbuild.exe /nologo /bl:D:\a_work\1\s\artifacts\log\Release\ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /m /nr:False /p:ContinuousIntegrationBuild=True /p:TreatWarningsAsErrors=false /p:__ToolsetLocationOutputFile=D:\a_work\1\s\artifacts\toolset\1.0.0-beta.22212.4.txt /t:__WriteToolsetLocation /v:minimal D:\a_work\1\s\artifacts\toolset\restore.proj
D:\a_work\1\s.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.22212.4\tools\Tools.proj : error MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.
##[error].packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.22212.4\tools\Tools.proj(0,0): error MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.
##[error]Build failed.

Gonna try the 1es images

@wtgodbe
Copy link
Member Author

wtgodbe commented May 4, 2022

Kestrel tests like TlsHandshakeRejectsTlsLessThan12 are now failing consistently with:

System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm.

This rings a bell, but I can't find old info about it - @halter73 @BrennanConroy @Tratcher does this look like a machine issue? It looks like these tests were deleted some time in the 5.0 time frame

@wtgodbe
Copy link
Member Author

wtgodbe commented May 5, 2022

@Tratcher @BrennanConroy @halter73 @JamesNK any ideas on the above?

@Tratcher
Copy link
Member

Tratcher commented May 5, 2022

The skip conditions have been updated in main.

[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10,
SkipReason = "Missing Windows ALPN support: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation#Support or incompatible ciphers on Windows 8.1")]

[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81,
SkipReason = "Missing Windows ALPN support: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation#Support")]

@wtgodbe wtgodbe merged commit 2c97b58 into dotnet:release/3.1 May 5, 2022
@wtgodbe wtgodbe deleted the wtgodbe/CompGov412 branch May 5, 2022 20:30
@dougbu dougbu modified the milestones: 3.1.x, 3.1.26 May 11, 2022
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants