Add redis startup error handling #41141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
force-pushed
the
brecon/rediserror
branch
from
f42c211 to
d1d16c3
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
halter73
reviewed
Jun 1, 2022
| Assert.Equal("Error connecting to Redis.", logs[0].Message); | ||
| Assert.Equal("throw from connect", logs[0].Exception.Message); | ||
| Assert.Equal("Error connecting to Redis.", logs[1].Message); | ||
| Assert.Equal("throw from connect", logs[1].Exception.Message); |
Member
There was a problem hiding this comment.
Do we really want to repeat this log every time a client connects or any time the app tries to publish a message? Would it be better to use a flag to see if we've already logged ErrorConnecting and not log again? I think the first error should be sufficient in most cases. And we're rethrowing in a way that the app and/or server can observe it except in the constructor which would throw the first exception which we'd still log anyway.
Member
Author
There was a problem hiding this comment.
Hmm good point. Although should we then unset the flag if the connection goes down again so it relogs?
Edit: Nvm, we have events for those
halter73
approved these changes
Jun 1, 2022
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Redis connection hasn't been established yet the
_busvariable wont be initialized. Normally this is fine, but if a connection comes in and the redis connection throws then you can get a null-ref whenOnDisconnectedAsyncis called.Additionally, adding logging for if the connection attempt throws.
Likely fixes #41104