Skip to content

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 6, 2022

  • root location does not work w/ CredScan check when pushing to AzDO mirror
  • instead, inform Guardian of CredScanSuppressions.json path

dougbu added 2 commits April 6, 2022 13:33
- root location does not work w/ `CredScan` check when pushing to AzDO mirror

This reverts commit cc3f45a.
@dougbu dougbu requested review from a team, Pilchie and wtgodbe as code owners April 6, 2022 20:39
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 6, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Apr 6, 2022

Tested a variant of this PR (with a password change, suppression to match, and SDL run in the build) in #20220404.5. The SDL build there failed for reasons unrelated to CredScan.

@dougbu
Copy link
Contributor Author

dougbu commented Apr 6, 2022

See https://github.com/dougbu/aspnetcore/compare/dougbu/revert.39780..dougbu/my.password for details of what was different for that internal build. Note as well that I was able to push the dougbu/my.password branch to the AzDO mirror.

@dougbu dougbu merged commit 1d38f87 into dotnet:main Apr 7, 2022
@dougbu dougbu deleted the dougbu/revert.39780 branch April 7, 2022 01:10
@ghost ghost added this to the 7.0-preview4 milestone Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants