Disable component governance in Linux_musl_x64_build #39898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
dougbu
reviewed
Jan 31, 2022
| $(_InternalRuntimeDownloadArgs) | ||
| installNodeJs: false | ||
| disableComponentGovernance: true | ||
| skipComponentGovernanceDetection: true |
Contributor
There was a problem hiding this comment.
do we still need skipComponentGovernanceDetection and the GC_RAN build step in default-build.yml❔
Member
Author
There was a problem hiding this comment.
I adopted a "if it ain't broke don't fix it mentality here". It appears to me that if disableComponentGovernance and skipComponentGovernanceDetection are set to the same value, then the same behavior will persist.
dougbu
approved these changes
Jan 31, 2022
wtgodbe
approved these changes
Jan 31, 2022
TanayParikh
added a commit
that referenced
this pull request
Feb 1, 2022
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1831254967 |
Contributor
|
@wtgodbe backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Disable component governance in Linux_musl_x64_build
Using index info to reconstruct a base tree...
M .azure/pipelines/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .azure/pipelines/ci.yml
CONFLICT (content): Merge conflict in .azure/pipelines/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable component governance in Linux_musl_x64_build
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
Extension of #39898
11 tasks
wtgodbe
added a commit
that referenced
this pull request
Feb 11, 2022
* Extend disable component governance for linux Extension of #39898 * PR Feedback * Update ci.yml Co-authored-by: Tanay Parikh <[email protected]> Co-authored-by: William Godbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issues with CG no longer respecting the
skipComponentGovernanceDetectionflag...