Skip to content

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Jan 21, 2022

A test client Cert expired today, skipping tests for now until cert can be regenerated

Example failing build: https://dev.azure.com/dnceng/public/_build/results?buildId=1563995&view=results

@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 21, 2022
@HaoK
Copy link
Member Author

HaoK commented Jan 21, 2022

@dotnet/aspnet-build okay if I force merge this since macOS has been unhappy all day and this skips a test that's broken in main

@HaoK HaoK requested review from a team and BrennanConroy January 21, 2022 03:47
@HaoK HaoK merged commit 26d3ba3 into main Jan 21, 2022
@HaoK HaoK deleted the haok/badcert branch January 21, 2022 03:48
@ghost ghost added this to the 7.0-preview1 milestone Jan 21, 2022
@dougbu
Copy link
Contributor

dougbu commented Jan 21, 2022

@dotnet/aspnet-build okay if I force merge this since macOS has been unhappy all day and this skips a test that's broken in main

:shipit:

@HaoK
Copy link
Member Author

HaoK commented Jan 21, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1730764317

@github-actions
Copy link
Contributor

@HaoK an error occurred while backporting to release/6.0, please check the run log for details!

Error: @HaoK is not a repo collaborator, backporting is not allowed.

@dougbu
Copy link
Contributor

dougbu commented Jan 21, 2022

@HaoK see #36832 (comment) for a workaround enabling you to use the backport bot.

@HaoK
Copy link
Member Author

HaoK commented Jan 21, 2022

/backport to release/6.0

@HaoK
Copy link
Member Author

HaoK commented Jan 21, 2022

/backport to release/5.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1730885428

@github-actions
Copy link
Contributor

Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1730885885

@github-actions
Copy link
Contributor

@HaoK backporting to release/5.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Skip failing cert tests for now
Using index info to reconstruct a base tree...
M	src/Security/Authentication/test/CertificateTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Security/Authentication/test/CertificateTests.cs
CONFLICT (content): Merge conflict in src/Security/Authentication/test/CertificateTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Skip failing cert tests for now
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants