Skip to content

Update Components.slnf #39602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jan 18, 2022
Merged

Update Components.slnf #39602

1 commit merged into from
Jan 18, 2022

Conversation

@SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Jan 18, 2022

Fixes #39601

@SteveSandersonMS SteveSandersonMS requested a review from a team January 18, 2022 13:40
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 18, 2022
SteveSandersonMS
SteveSandersonMS commented Jan 18, 2022
View reviewed changes
src/Components/Components.slnf
]
}
}
}
Copy link
Member Author

@SteveSandersonMS SteveSandersonMS Jan 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update was generated by VS. I think we should not fight its views on trailing linebreaks or ordering.

@ghost
Copy link

ghost commented Jan 18, 2022

Hello @SteveSandersonMS!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 20 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

pranavkm
pranavkm approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the NoDeps project also need to be updated?

@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Jan 18, 2022

Does the NoDeps project also need to be updated?

It doesn't look like it, since that one doesn't include dependencies like this. It doesn't have any of the other Kestrel projects, for example.

@ghost ghost merged commit 2325e12 into main Jan 18, 2022
@ghost ghost deleted the steves/update-components-slnf branch January 18, 2022 15:33
@MariovanZeist MariovanZeist mentioned this pull request Jan 19, 2022
Closed
ShreyasJejurkar pushed a commit to ShreyasJejurkar/aspnetcore that referenced this pull request Jan 22, 2022
@SteveSandersonMS @ShreyasJejurkar
Update Components.slnf (dotnet#39602)
82e29e4
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pranavkm pranavkm pranavkm approved these changes

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error building src/Components in VS 2022

4 participants

@SteveSandersonMS @pranavkm @TanayParikh