Cache property intiailizers for the duration of component lifetime #39450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComponentFactory is instantiated on a per-renderer basis. It has a cache that stores property initializers in a state independent way. In a Blazor server app, there is a HtmlRenderer created during pre-rendering and a per-circuit renderer which means we're calculating and allocating multiple copies of property intializers.
ghost
added
the
ShreyasJejurkar
pushed a commit
to ShreyasJejurkar/aspnetcore
that referenced
this pull request
Jan 22, 2022
…otnet#39450) ComponentFactory is instantiated on a per-renderer basis. It has a cache that stores property initializers in a state independent way. In a Blazor server app, there is a HtmlRenderer created during pre-rendering and a per-circuit renderer which means we're calculating and allocating multiple copies of property intializers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentFactory is instantiated on a per-renderer basis. It has a cache that stores
property initializers in a state independent way. In a Blazor server app, there is a HtmlRenderer created
during pre-rendering and a per-circuit renderer which means we're calculating (reflection) and allocating multiple
copies of property initializers. Turning it into a static avoids this.