Revert "Remove source-build workaround for sourcelink submodule issue"

[MichaelSimons]

This reverts commit 9b049bd (#39324) as the change broke the internal builds. See https://github.com/dotnet/aspnetcore-internal/issues/3979#issuecomment-1006801036.

[dougbu]

@dotnet/aspnet-build should we merge this pre-emptively to get builds working again❔ In particular, public builds aren't failing so the CI validation here proves nothing.

[wtgodbe]

No objections here

[dougbu]

Latest official build worked❕

Now, main question is why public source-build jobs worked but internal ones did not. Any ideas @MichaelSimons❔

[MichaelSimons]

I don't have any idea. The only difference that I see is the Agent pool. The source build jobs run in a container which I would expect us to be isolated from most machine config changes.

[ghost]

Hi @MichaelSimons. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[dougbu]

Hmm, there are a couple of differences in our YAML between public and internal, including a few from Arcade-powered Source Build itself. Eg. $(_PublishArgs) is empty in public builds and the following internally:

  - name: _PublishArgs
    value: /p:Publish=true
           /p:GenerateChecksums=true
           /p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
           /p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
           /p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
           /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
           /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)

We use that variable in the source-build.yml job: buildScript: './eng/build.sh $(_PublishArgs) --no-build-repo-tasks'. But, I don't understand how those msbuild properties could cause the submodule failures we saw…

[dougbu]

@MichaelSimons could you have a look at https://artprodcus3.artifacts.visualstudio.com/Ab55de4ed-4b5a-4215-a8e4-0a0a5f71e7d8/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2RuY2VuZy9wcm9qZWN0SWQvN2VhOTExNmUtOWZhYy00MDNkLWIyNTgtYjMxZmNmMWJiMjkzL2J1aWxkSWQvMTUzOTQ1Mi9hcnRpZmFjdE5hbWUvQnVpbGRMb2dzX1NvdXJjZUJ1aWxkX01hbmFnZWRfQXR0ZW1wdDE1/content?format=file&subPath=%2Fartifacts%2Flog%2FRelease%2FBuild.binlog and see what you can see please❔

[kasperk81]

dotnet/sourcelink#653 was fixed by @tmat in 2018. perhaps file a new issue?

[MichaelSimons]

We are tracking the backport of this patch with dotnet/source-build#2708.