Skip to content

NewtonsoftJsonInputFormatter checks for ErrorContext.Handled flag (#37323) #39275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2022
Merged

NewtonsoftJsonInputFormatter checks for ErrorContext.Handled flag (#37323) #39275

merged 3 commits into from
Jan 3, 2022

Conversation

@gbtb
Copy link
Contributor

@gbtb gbtb commented Jan 3, 2022

NewtonsoftJsonInputFormatter checks for ErrorContext.Handled flag

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Added check for eventArgs.ErrorContext.Handled flag before reporting error.

Fixes #37323

@gbtb gbtb requested review from javiercn and pranavkm as code owners January 3, 2022 12:38
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Jan 3, 2022
@dnfadmin
Copy link

dnfadmin commented Jan 3, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@mkArtakMSFT mkArtakMSFT added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jan 3, 2022
pranavkm
pranavkm approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@pranavkm pranavkm enabled auto-merge (squash) January 3, 2022 16:33
@pranavkm pranavkm merged commit c417418 into dotnet:main Jan 3, 2022
@ghost ghost added this to the 7.0-preview1 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn Awaiting requested review from javiercn

2 more reviewers

@TanayParikh TanayParikh TanayParikh left review comments

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rafikiassumani-msft rafikiassumani-msft

Labels

community-contribution Indicates that the PR has been added by a community member old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

NewtonsoftJsonInputFormatter has incorrect behavior in case of user-added EventHandler

6 participants

@gbtb @dnfadmin @pranavkm @TanayParikh @mkArtakMSFT @rafikiassumani-msft