Skip to content

Backport Use CDN for .NET Assets for release/3.1 #39046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2021
Merged

Backport Use CDN for .NET Assets for release/3.1 #39046

merged 3 commits into from
Dec 17, 2021

Conversation

@TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Dec 15, 2021

@TanayParikh TanayParikh added the tell-mode Indicates a PR which is being merged during tell-mode label Dec 15, 2021
@TanayParikh TanayParikh requested a review from dougbu as a code owner December 15, 2021 00:49
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 15, 2021
@ghost ghost added this to the 3.1.x milestone Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @TanayParikh. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@TanayParikh TanayParikh mentioned this pull request Dec 15, 2021
Merged
@dougbu
Copy link
Contributor

dougbu commented Dec 15, 2021

@MattGal is this change correct for release/3.1❔ Seeing errors like the following in most build jobs:

error : Problems downloading file from 'https://dotnetbuilds.azureedge.net/public/Runtime/3.1.21-servicing.21522.1/dotnet-runtime-3.1.21-win-x64.zip'. Does the resource exist on the storage? NotFound : Not Found

@MattGal
Copy link
Member

MattGal commented Dec 15, 2021 •
edited
Loading

@MattGal is this change correct for release/3.1❔ Seeing errors like the following in most build jobs:

error : Problems downloading file from 'https://dotnetbuilds.azureedge.net/public/Runtime/3.1.21-servicing.21522.1/dotnet-runtime-3.1.21-win-x64.zip'. Does the resource exist on the storage? NotFound : Not Found

No it's not, I'm not sure how far back it goes but I wouldn't expect anywhere @alexperovich didn't plan for it to go. I'll peek at what's in there and report back. (I'm also attempting to pursue the problem with blob storage accounts and Hosted MacOS machines now and will escalate if I don't have a reply today)

@MattGal
Copy link
Member

MattGal commented Dec 15, 2021

@dougbu / @TanayParikh there's nothing earlier than 6.x in dotnetbuilds, so you can't use this approach. Instead just use the existing CDN versus blob storage URL (dotnetcli.azureedge.net)

@TanayParikh TanayParikh mentioned this pull request Dec 15, 2021
Merged
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Dec 15, 2021

Not working with dotnetcli.azureedge.net either, leaving as is.

@TanayParikh TanayParikh deleted the TanayParikh-patch-3 branch December 15, 2021 17:59
@dougbu dougbu removed this from the 3.1.x milestone Dec 15, 2021
@TanayParikh TanayParikh restored the TanayParikh-patch-3 branch December 16, 2021 22:16
@TanayParikh TanayParikh reopened this Dec 16, 2021
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Dec 17, 2021

@dotnet/aspnet-build requesting merge please.

@dougbu dougbu merged commit 47356f1 into release/3.1 Dec 17, 2021
@dougbu dougbu deleted the TanayParikh-patch-3 branch December 17, 2021 01:55
@dougbu dougbu added this to the 3.1.23 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

3.1.23

Development

Successfully merging this pull request may close these issues.

4 participants

@TanayParikh @dougbu @MattGal