Skip to content

[main] Special case X.Y.1 in Directory.Build.targets.in #38047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

[main] Special case X.Y.1 in Directory.Build.targets.in #38047

merged 1 commit into from
Nov 3, 2021

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Nov 3, 2021

@dougbu
[main] Special case X.Y.1 in Directory.Build.targets.in
460316c 
- see <711d9dc>
  - avoid problems in 7.0.1 between rebranding and 7.0.0 release
- do not update `%(TargetingPackVersion)` until X.Y.0 versions have been released
  - address an odd timing issue I missed in #37120
  - fine to stick w/ SDK's bundled targeting pack for one release
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 3, 2021
@dougbu dougbu requested a review from a team November 3, 2021 03:29
@dougbu dougbu merged commit 9c7f136 into dotnet:main Nov 3, 2021
@dougbu dougbu deleted the dougbu/x.y.1 branch November 3, 2021 17:37
@ghost ghost added this to the 7.0-preview1 milestone Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

2 participants

@dougbu @wtgodbe