Fix virtualization handling of large dataset length changes. Fixes #37245 #37247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1303305899 |
Merged
10 tasks
SteveSandersonMS
deleted the
stevesa/fix-virtualization-dataset-length-changes
branch
ghost
added this to the
mkArtakMSFT
pushed a commit
that referenced
this pull request
Oct 5, 2021
…7245 (#37250) Backport of #37247 to release/6.0 /cc @SteveSandersonMS ## Description/Customer Impact The `Virtualize` component exhibits pathological behavior in the following case: * User scrolls to the end of a very long list (e.g., 100000 items) * The list becomes much shorter (e.g., 100 items) Instead of jumping back to the new maximum scroll position, it incrementally steps back to it one page at a time. In the above example, if the scroll region is tall enough for 20 items, that would take (100000-100)/20 = 4995 steps. On each step it requests a new data set (possibly causing an HTTP request and DB query) and a UI re-render. Eventually this does complete, but it's extraordinarily inefficient. It's very trivial to fix this so that we move to the correct final scroll offset in a single step. ## Regression? - [ ] Yes - [X] No ## Risk - [ ] High - [ ] Medium - [X] Low * Change was verified manually and via a new E2E test * The code change is trivial: we can detect and correct the invalid scroll offset in a single step. The new logic shouldn't affect any existing case where the scroll offset was valid. ## Verification - [X] Manual (required) - [X] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A Fixes #37245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #37245
This is a really small and simple change to
Virtualize.cs. We just detect the invalid offset and clamp it back to the valid range. It shouldn't affect any case where the offset is valid.Most of this PR is just the E2E test coverage.