Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 28, 2021

Backport of #37043 to release/6.0

/cc @adityamandaleeka

Customer Impact

The fix here is in the event name, which someone may use to search/filter.

Testing

Risk

Minimal. This is a typo fix in logging added in 6. Fixing this now will help us avoid a breaking change later if any code starts to depend on this.

@adityamandaleeka
Copy link
Member

@dougbu I discussed this with @Pilchie too. Will hold off on signing off here until I get a review on the version of this in main though.

@dougbu
Copy link
Contributor

dougbu commented Sep 28, 2021

Lemme know when you're ready for a merge @adityamandaleeka. Suggest marking as Servicing-approved so nobody asks again 😃

@adityamandaleeka adityamandaleeka added the Servicing-approved Shiproom has approved the issue label Sep 28, 2021
@adityamandaleeka
Copy link
Member

@dougbu Thanks, ready now that I've gotten a couple of signoffs.

@dougbu dougbu merged commit 092ae99 into release/6.0 Sep 28, 2021
@dougbu dougbu deleted the backport/pr-37043-to-release/6.0 branch September 28, 2021 17:33
@ghost ghost added this to the 6.0.0 milestone Sep 28, 2021
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants